Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(git changelog): resolve profile picture for GitHub emails, new option to hide no data texts #293

Merged
merged 5 commits into from
Aug 3, 2024
Merged

feat(git changelog): resolve profile picture for GitHub emails, new option to hide no data texts #293

merged 5 commits into from
Aug 3, 2024

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Aug 2, 2024

Resolve profile pictures for GitHub emails in commit authors.

Resolves #277

Based on @nekomeowww's suggestions: #277 (comment)

@nekomeowww nekomeowww added enhancement New feature or request pkg/git-changelog Related to @nolebase/vitepress-plugin-git-changelog difficulty/medium Medium level to deal with / implement against labels Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

✅ Successfully deployed to Netlify

Platform Status URL
Ubuntu Success https://66ad9101fe7aad12d62182a2--nolebase-integrations.netlify.app
Windows Success https://66ad910e3cf2b404fdb520d2--nolebase-integrations.netlify.app

nekomeowww
nekomeowww previously approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for @northword

@giladgd
Copy link
Contributor Author

giladgd commented Aug 2, 2024

@nekomeowww I meant to push feat(git changelog): hide "no changes" text option to a new branch and open a new PR, but I accidentally pushed it here.
Is it ok or should I revert it and open a new PR instead?

northword
northword approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@northword northword left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nekomeowww
Copy link
Member

@nekomeowww I meant to push feat(git changelog): hide "no changes" text option to a new branch and open a new PR, but I accidentally pushed it here.

Is it ok or should I revert it and open a new PR instead?

I think its ok.

@nekomeowww nekomeowww changed the title feat(git changelog): resolve profile picture for GitHub emails feat(git changelog): resolve profile picture for GitHub emails, new option to hide no data texts Aug 3, 2024
@nekomeowww nekomeowww enabled auto-merge (squash) August 3, 2024 06:33
@nekomeowww nekomeowww merged commit b6ae060 into nolebase:main Aug 3, 2024
6 checks passed
@taskylizard
Copy link

taskylizard commented Aug 3, 2024 •
edited
Loading

Many thanks for implementing my feature request! ❤️

@northword northword mentioned this pull request Aug 4, 2024
Merged
@giladgd giladgd deleted the profilePictures branch October 5, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekomeowww nekomeowww nekomeowww approved these changes

@northword northword northword approved these changes

Assignees
No one assigned
Labels
difficulty/medium Medium level to deal with / implement against enhancement New feature or request pkg/git-changelog Related to @nolebase/vitepress-plugin-git-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request(git-changelog): use github authors avatars by default
4 participants
@giladgd @nekomeowww @taskylizard @northword